Standardise the team member commands. Closes #1881

This commit is contained in:
James Brooks
2016-07-21 11:45:40 +01:00
parent ef9f7d23a0
commit e15af44449
7 changed files with 49 additions and 28 deletions

View File

@@ -11,7 +11,12 @@
namespace CachetHQ\Cachet\Bus\Commands\User;
final class AddTeamMemberCommand
/**
* This is the add user command.
*
* @author James Brooks <james@alt-three.com>
*/
final class AddUserCommand
{
/**
* The user username.

View File

@@ -11,7 +11,12 @@
namespace CachetHQ\Cachet\Bus\Commands\User;
final class InviteTeamMemberCommand
/**
* This is the invite user command.
*
* @author James Brooks <james@alt-three.com>
*/
final class InviteUserCommand
{
/**
* The invite emails.
@@ -30,7 +35,7 @@ final class InviteTeamMemberCommand
];
/**
* Create a new invite team member command instance.
* Create a new invite user command instance.
*
* @param string[] $emails
*

View File

@@ -11,20 +11,25 @@
namespace CachetHQ\Cachet\Bus\Handlers\Commands\User;
use CachetHQ\Cachet\Bus\Commands\User\AddTeamMemberCommand;
use CachetHQ\Cachet\Bus\Commands\User\AddUserCommand;
use CachetHQ\Cachet\Bus\Events\User\UserWasAddedEvent;
use CachetHQ\Cachet\Models\User;
class AddTeamMemberCommandHandler
/**
* This is the add user command handler.
*
* @author James Brooks <james@alt-three.com>
*/
class AddUserCommandHandler
{
/**
* Handle the add team member command.
* Handle the add user command.
*
* @param \CachetHQ\Cachet\Bus\Commands\User\AddTeamMemberCommand $command
* @param \CachetHQ\Cachet\Bus\Commands\User\AddUserCommand $command
*
* @return \CachetHQ\Cachet\Models\User
*/
public function handle(AddTeamMemberCommand $command)
public function handle(AddUserCommand $command)
{
$user = User::create([
'username' => $command->username,

View File

@@ -11,20 +11,25 @@
namespace CachetHQ\Cachet\Bus\Handlers\Commands\User;
use CachetHQ\Cachet\Bus\Commands\User\InviteTeamMemberCommand;
use CachetHQ\Cachet\Bus\Commands\User\InviteUserCommand;
use CachetHQ\Cachet\Bus\Events\User\UserWasInvitedEvent;
use CachetHQ\Cachet\Models\Invite;
class InviteTeamMemberCommandHandler
/**
* This is the invite user command handler.
*
* @author James Brooks <james@alt-three.com>
*/
class InviteUserCommandHandler
{
/**
* Handle the invite team member command.
*
* @param \CachetHQ\Cachet\Bus\Commands\User\InviteTeamMemberCommand $command
* @param \CachetHQ\Cachet\Bus\Commands\User\InviteUserCommand $command
*
* @return void
*/
public function handle(InviteTeamMemberCommand $command)
public function handle(InviteUserCommand $command)
{
foreach ($command->emails as $email) {
$invite = Invite::create([

View File

@@ -12,8 +12,8 @@
namespace CachetHQ\Cachet\Http\Controllers\Dashboard;
use AltThree\Validator\ValidationException;
use CachetHQ\Cachet\Bus\Commands\User\AddTeamMemberCommand;
use CachetHQ\Cachet\Bus\Commands\User\InviteTeamMemberCommand;
use CachetHQ\Cachet\Bus\Commands\User\AddUserCommand;
use CachetHQ\Cachet\Bus\Commands\User\InviteUserCommand;
use CachetHQ\Cachet\Bus\Commands\User\RemoveUserCommand;
use CachetHQ\Cachet\Models\User;
use GrahamCampbell\Binput\Facades\Binput;
@@ -81,7 +81,7 @@ class TeamController extends Controller
public function postAddUser()
{
try {
dispatch(new AddTeamMemberCommand(
dispatch(new AddUserCommand(
Binput::get('username'),
Binput::get('password'),
Binput::get('email'),
@@ -130,7 +130,7 @@ class TeamController extends Controller
public function postInviteUser()
{
try {
dispatch(new InviteTeamMemberCommand(
dispatch(new InviteUserCommand(
array_unique(array_filter((array) Binput::get('emails')))
));
} catch (ValidationException $e) {

View File

@@ -12,17 +12,17 @@
namespace CachetHQ\Tests\Cachet\Bus\Commands\User;
use AltThree\TestBench\CommandTrait;
use CachetHQ\Cachet\Bus\Commands\User\AddTeamMemberCommand;
use CachetHQ\Cachet\Bus\Handlers\Commands\User\AddTeamMemberCommandHandler;
use CachetHQ\Cachet\Bus\Commands\User\AddUserCommand;
use CachetHQ\Cachet\Bus\Handlers\Commands\User\AddUserCommandHandler;
use CachetHQ\Tests\Cachet\AbstractTestCase;
/**
* This is the add team member command test class.
* This is the add user command test class.
*
* @author James Brooks <james@alt-three.com>
* @author Graham Campbell <graham@alt-three.com>
*/
class AddTeamMemberCommandTest extends AbstractTestCase
class AddUserCommandTest extends AbstractTestCase
{
use CommandTrait;
@@ -35,7 +35,7 @@ class AddTeamMemberCommandTest extends AbstractTestCase
'level' => 1,
];
$object = new AddTeamMemberCommand(
$object = new AddUserCommand(
$params['username'],
$params['password'],
$params['email'],
@@ -52,6 +52,6 @@ class AddTeamMemberCommandTest extends AbstractTestCase
protected function getHandlerClass()
{
return AddTeamMemberCommandHandler::class;
return AddUserCommandHandler::class;
}
}

View File

@@ -12,23 +12,24 @@
namespace CachetHQ\Tests\Cachet\Bus\Commands\User;
use AltThree\TestBench\CommandTrait;
use CachetHQ\Cachet\Bus\Commands\User\InviteTeamMemberCommand;
use CachetHQ\Cachet\Bus\Handlers\Commands\User\InviteTeamMemberCommandHandler;
use CachetHQ\Cachet\Bus\Commands\User\InviteUserCommand;
use CachetHQ\Cachet\Bus\Handlers\Commands\User\InviteUserCommandHandler;
use CachetHQ\Tests\Cachet\AbstractTestCase;
/**
* This is the invite team member command test class.
* This is the invite user command test class.
*
* @author Graham Campbell <graham@alt-three.com>
* @author James Brooks <graham@alt-three.com>
*/
class InviteTeamMemberCommandTest extends AbstractTestCase
class InviteUserCommandTest extends AbstractTestCase
{
use CommandTrait;
protected function getObjectAndParams()
{
$params = ['emails' => ['foo@example.com']];
$object = new InviteTeamMemberCommand($params['emails']);
$object = new InviteUserCommand($params['emails']);
return compact('params', 'object');
}
@@ -40,6 +41,6 @@ class InviteTeamMemberCommandTest extends AbstractTestCase
protected function getHandlerClass()
{
return InviteTeamMemberCommandHandler::class;
return InviteUserCommandHandler::class;
}
}