Merge pull request #1173 from cachethq/fixes

Fix some nulls and the notifications on the handlers

app/Handlers/Commands/Incident/ReportIncidentCommandHandler.php

@@ -84,6 +84,8 @@ class ReportIncidentCommandHandler
             ]);
         }
 
+        $incident->notify = (bool) $command->notify;
+
         event(new IncidentWasReportedEvent($incident));
 
         return $incident;

app/Handlers/Commands/Incident/ReportMaintenanceCommandHandler.php

@@ -56,6 +56,8 @@ class ReportMaintenanceCommandHandler
             'visible'      => 1,
         ]);
 
+        $maintenanceEvent->notify = (bool) $command->notify;
+
         event(new MaintenanceWasScheduledEvent($maintenanceEvent));
 
         return $maintenanceEvent;

app/Http/Controllers/SignupController.php

@@ -36,7 +36,7 @@ class SignupController extends Controller
      */
     public function getSignup($code = null)
     {
-        if ($code !== null) {
+        if ($code === null) {
             throw new NotFoundHttpException();
         }
 
@@ -61,7 +61,7 @@ class SignupController extends Controller
      */
     public function postSignup($code = null)
     {
-        if ($code !== null) {
+        if ($code === null) {
             throw new NotFoundHttpException();
         }
 

app/Http/Controllers/SubscribeController.php

@@ -70,7 +70,7 @@ class SubscribeController extends Controller
      */
     public function getVerify($code = null)
     {
-        if ($code !== null) {
+        if ($code === null) {
             throw new NotFoundHttpException();
         }
 
@@ -95,7 +95,7 @@ class SubscribeController extends Controller
      */
     public function getUnsubscribe($code = null)
     {
-        if ($code !== null) {
+        if ($code === null) {
             throw new NotFoundHttpException();
         }