During the setup the "mail_username" was required and it was then
undone, so using the sendmail driver we can let the username empty.
It would be bad to let the username optional for every drivers, because
in some configurations, like SMTP, the username is required for the SMTP
server so if the user let it empty its mail configuration will be bad.
The mail_username is now optional only if the mail driver is sendmail.
See: #3244
During the setup process email informations were asked:
- Driver
- Host
- Username
- Password
In some situations the username is not useful because the Cachet's
host may be configured to forward email to a server.
The problem is the username was required, so we had to set a username
and then update the .env file to remove it.
To fix this problem, the mail username has been set to optional in
the setup. So if someone needs a username it still can use this field,
and otherwise people can let it empty.
See: #3244
In the settings we can upload an image as banner. There are some
verifications that are done on the file to check that it's a valid
image.
If the file is not valid, a redirection is done to the theme page with
an error message.
When redirecting to the theme page because of an error on the file, the
controller redirects to an URL set in a variable. The problem was this
variable '$redirectUrl' was undefined, so the controller thrown an
error. The problem occured only if there was an error on the file, but
it worked well if the file was a valid image.
In the controller's constructor a 'submenu' field is set with panel
items and url, so the variable '$redirectUrl' is set to the theme
page URL. Now if there is an error with the file, the user is well
redirected and the error is displayed.
See: CachetHQ/Cachet#2956
