Refactors out notify conditions. Closes #1083

app/Handlers/Commands/Incident/ReportMaintenanceCommandHandler.php

@@ -41,9 +41,7 @@ class ReportMaintenanceCommandHandler
         ]);
 
         // Notify subscribers.
-        if ($command->notify) {
+        event(new MaintenanceWasScheduledEvent($maintenanceEvent));
-            event(new MaintenanceWasScheduledEvent($maintenanceEvent));
-        }
 
         return $maintenanceEvent;
     }

app/Handlers/Commands/Incident/UpdateIncidentCommandHandler.php

@@ -50,9 +50,7 @@ class UpdateIncidentCommandHandler
         }
 
         // Notify subscribers.
-        if ($command->notify) {
+        event(new IncidentWasUpdatedEvent($incident));
-            event(new IncidentWasUpdatedEvent($incident));
-        }
 
         return $incident;
     }

app/Handlers/Events/Incident/SendIncidentEmailNotificationHandler.php

@@ -56,6 +56,10 @@ class SendIncidentEmailNotificationHandler
      */
     public function handle(IncidentWasReportedEvent $event)
     {
+        if (!$event->incident->notify) {
+            return false;
+        }
+
         $incident = AutoPresenter::decorate($event->incident);
         $component = AutoPresenter::decorate($event->incident->component);
 

app/Handlers/Events/Incident/SendMaintenanceEmailNotificationHandler.php

@@ -56,6 +56,10 @@ class SendMaintenanceEmailNotificationHandler
      */
     public function handle(MaintenanceWasScheduledEvent $event)
     {
+        if (!$event->incident->notify) {
+            return false;
+        }
+
         $data = AutoPresenter::decorate($event->incident);
 
         foreach ($this->subscriber->all() as $subscriber) {