From eb874ade0fa63e3d03feb658c40cf89dffd64e78 Mon Sep 17 00:00:00 2001 From: James Brooks Date: Fri, 25 Dec 2015 16:04:15 +0000 Subject: [PATCH 1/8] Make all events final classes --- app/Events/Component/ComponentWasAddedEvent.php | 2 +- app/Events/Component/ComponentWasRemovedEvent.php | 2 +- app/Events/Component/ComponentWasUpdatedEvent.php | 2 +- app/Events/ComponentGroup/ComponentGroupWasAddedEvent.php | 2 +- app/Events/ComponentGroup/ComponentGroupWasRemovedEvent.php | 2 +- app/Events/ComponentGroup/ComponentGroupWasUpdatedEvent.php | 2 +- app/Events/Incident/IncidentWasRemovedEvent.php | 2 +- app/Events/Incident/IncidentWasReportedEvent.php | 2 +- app/Events/Incident/IncidentWasUpdatedEvent.php | 2 +- app/Events/Incident/MaintenanceWasScheduledEvent.php | 2 +- app/Events/Metric/MetricPointWasAddedEvent.php | 2 +- app/Events/Metric/MetricPointWasRemovedEvent.php | 2 +- app/Events/Metric/MetricPointWasUpdatedEvent.php | 2 +- app/Events/Metric/MetricWasAddedEvent.php | 2 +- app/Events/Metric/MetricWasRemovedEvent.php | 2 +- app/Events/Metric/MetricWasUpdatedEvent.php | 2 +- app/Events/Subscriber/SubscriberHasSubscribedEvent.php | 2 +- app/Events/Subscriber/SubscriberHasUnsubscribedEvent.php | 2 +- app/Events/Subscriber/SubscriberHasVerifiedEvent.php | 2 +- app/Events/User/UserWasInvitedEvent.php | 2 +- 20 files changed, 20 insertions(+), 20 deletions(-) diff --git a/app/Events/Component/ComponentWasAddedEvent.php b/app/Events/Component/ComponentWasAddedEvent.php index c3332161..7aacd7e6 100644 --- a/app/Events/Component/ComponentWasAddedEvent.php +++ b/app/Events/Component/ComponentWasAddedEvent.php @@ -13,7 +13,7 @@ namespace CachetHQ\Cachet\Events\Component; use CachetHQ\Cachet\Models\Component; -class ComponentWasAddedEvent implements ComponentEventInterface +final class ComponentWasAddedEvent implements ComponentEventInterface { /** * The component that was added. diff --git a/app/Events/Component/ComponentWasRemovedEvent.php b/app/Events/Component/ComponentWasRemovedEvent.php index 6c28bca4..838e9c93 100644 --- a/app/Events/Component/ComponentWasRemovedEvent.php +++ b/app/Events/Component/ComponentWasRemovedEvent.php @@ -13,7 +13,7 @@ namespace CachetHQ\Cachet\Events\Component; use CachetHQ\Cachet\Models\Component; -class ComponentWasRemovedEvent implements ComponentEventInterface +final class ComponentWasRemovedEvent implements ComponentEventInterface { /** * The component that was removed. diff --git a/app/Events/Component/ComponentWasUpdatedEvent.php b/app/Events/Component/ComponentWasUpdatedEvent.php index 4d3daecb..5a2b626b 100644 --- a/app/Events/Component/ComponentWasUpdatedEvent.php +++ b/app/Events/Component/ComponentWasUpdatedEvent.php @@ -13,7 +13,7 @@ namespace CachetHQ\Cachet\Events\Component; use CachetHQ\Cachet\Models\Component; -class ComponentWasUpdatedEvent implements ComponentEventInterface +final class ComponentWasUpdatedEvent implements ComponentEventInterface { /** * The component that was updated. diff --git a/app/Events/ComponentGroup/ComponentGroupWasAddedEvent.php b/app/Events/ComponentGroup/ComponentGroupWasAddedEvent.php index b6760be1..868b7d0e 100644 --- a/app/Events/ComponentGroup/ComponentGroupWasAddedEvent.php +++ b/app/Events/ComponentGroup/ComponentGroupWasAddedEvent.php @@ -13,7 +13,7 @@ namespace CachetHQ\Cachet\Events\ComponentGroup; use CachetHQ\Cachet\Models\ComponentGroup; -class ComponentGroupWasAddedEvent implements ComponentGroupEventInterface +final class ComponentGroupWasAddedEvent implements ComponentGroupEventInterface { /** * The component group that was added. diff --git a/app/Events/ComponentGroup/ComponentGroupWasRemovedEvent.php b/app/Events/ComponentGroup/ComponentGroupWasRemovedEvent.php index b32c9e45..4231ed88 100644 --- a/app/Events/ComponentGroup/ComponentGroupWasRemovedEvent.php +++ b/app/Events/ComponentGroup/ComponentGroupWasRemovedEvent.php @@ -13,7 +13,7 @@ namespace CachetHQ\Cachet\Events\ComponentGroup; use CachetHQ\Cachet\Models\ComponentGroup; -class ComponentGroupWasRemovedEvent implements ComponentGroupEventInterface +final class ComponentGroupWasRemovedEvent implements ComponentGroupEventInterface { /** * The component group that was removed. diff --git a/app/Events/ComponentGroup/ComponentGroupWasUpdatedEvent.php b/app/Events/ComponentGroup/ComponentGroupWasUpdatedEvent.php index c70a3165..8eb58d7e 100644 --- a/app/Events/ComponentGroup/ComponentGroupWasUpdatedEvent.php +++ b/app/Events/ComponentGroup/ComponentGroupWasUpdatedEvent.php @@ -13,7 +13,7 @@ namespace CachetHQ\Cachet\Events\ComponentGroup; use CachetHQ\Cachet\Models\ComponentGroup; -class ComponentGroupWasUpdatedEvent implements ComponentGroupEventInterface +final class ComponentGroupWasUpdatedEvent implements ComponentGroupEventInterface { /** * The component group that was updated. diff --git a/app/Events/Incident/IncidentWasRemovedEvent.php b/app/Events/Incident/IncidentWasRemovedEvent.php index 2ea4934f..a53060a2 100644 --- a/app/Events/Incident/IncidentWasRemovedEvent.php +++ b/app/Events/Incident/IncidentWasRemovedEvent.php @@ -13,7 +13,7 @@ namespace CachetHQ\Cachet\Events\Incident; use CachetHQ\Cachet\Models\Incident; -class IncidentWasRemovedEvent implements IncidentEventInterface +final class IncidentWasRemovedEvent implements IncidentEventInterface { /** * The incident that has been removed. diff --git a/app/Events/Incident/IncidentWasReportedEvent.php b/app/Events/Incident/IncidentWasReportedEvent.php index 00eb6930..a791dd8f 100644 --- a/app/Events/Incident/IncidentWasReportedEvent.php +++ b/app/Events/Incident/IncidentWasReportedEvent.php @@ -13,7 +13,7 @@ namespace CachetHQ\Cachet\Events\Incident; use CachetHQ\Cachet\Models\Incident; -class IncidentWasReportedEvent implements IncidentEventInterface +final class IncidentWasReportedEvent implements IncidentEventInterface { /** * The incident that has been reported. diff --git a/app/Events/Incident/IncidentWasUpdatedEvent.php b/app/Events/Incident/IncidentWasUpdatedEvent.php index a5352b28..52b847d0 100644 --- a/app/Events/Incident/IncidentWasUpdatedEvent.php +++ b/app/Events/Incident/IncidentWasUpdatedEvent.php @@ -13,7 +13,7 @@ namespace CachetHQ\Cachet\Events\Incident; use CachetHQ\Cachet\Models\Incident; -class IncidentWasUpdatedEvent implements IncidentEventInterface +final class IncidentWasUpdatedEvent implements IncidentEventInterface { /** * The incident that has been updated. diff --git a/app/Events/Incident/MaintenanceWasScheduledEvent.php b/app/Events/Incident/MaintenanceWasScheduledEvent.php index 688940be..7ccce3e2 100644 --- a/app/Events/Incident/MaintenanceWasScheduledEvent.php +++ b/app/Events/Incident/MaintenanceWasScheduledEvent.php @@ -13,7 +13,7 @@ namespace CachetHQ\Cachet\Events\Incident; use CachetHQ\Cachet\Models\Incident; -class MaintenanceWasScheduledEvent implements IncidentEventInterface +final class MaintenanceWasScheduledEvent implements IncidentEventInterface { /** * The incident that has been reported. diff --git a/app/Events/Metric/MetricPointWasAddedEvent.php b/app/Events/Metric/MetricPointWasAddedEvent.php index d2c8a2b3..e081f024 100644 --- a/app/Events/Metric/MetricPointWasAddedEvent.php +++ b/app/Events/Metric/MetricPointWasAddedEvent.php @@ -13,7 +13,7 @@ namespace CachetHQ\Cachet\Events\Metric; use CachetHQ\Cachet\Models\MetricPoint; -class MetricPointWasAddedEvent implements MetricEventInterface +final class MetricPointWasAddedEvent implements MetricEventInterface { /** * The metric point that was added. diff --git a/app/Events/Metric/MetricPointWasRemovedEvent.php b/app/Events/Metric/MetricPointWasRemovedEvent.php index 7b919495..18a83051 100644 --- a/app/Events/Metric/MetricPointWasRemovedEvent.php +++ b/app/Events/Metric/MetricPointWasRemovedEvent.php @@ -13,7 +13,7 @@ namespace CachetHQ\Cachet\Events\Metric; use CachetHQ\Cachet\Models\MetricPoint; -class MetricPointWasRemovedEvent implements MetricEventInterface +final class MetricPointWasRemovedEvent implements MetricEventInterface { /** * The metric point that was removed. diff --git a/app/Events/Metric/MetricPointWasUpdatedEvent.php b/app/Events/Metric/MetricPointWasUpdatedEvent.php index ce2ea986..d1d9e0b0 100644 --- a/app/Events/Metric/MetricPointWasUpdatedEvent.php +++ b/app/Events/Metric/MetricPointWasUpdatedEvent.php @@ -13,7 +13,7 @@ namespace CachetHQ\Cachet\Events\Metric; use CachetHQ\Cachet\Models\MetricPoint; -class MetricPointWasUpdatedEvent implements MetricEventInterface +final class MetricPointWasUpdatedEvent implements MetricEventInterface { /** * The metric point that was updated. diff --git a/app/Events/Metric/MetricWasAddedEvent.php b/app/Events/Metric/MetricWasAddedEvent.php index bbc14664..c097f090 100644 --- a/app/Events/Metric/MetricWasAddedEvent.php +++ b/app/Events/Metric/MetricWasAddedEvent.php @@ -13,7 +13,7 @@ namespace CachetHQ\Cachet\Events\Metric; use CachetHQ\Cachet\Models\Metric; -class MetricWasAddedEvent implements MetricEventInterface +final class MetricWasAddedEvent implements MetricEventInterface { /** * The metric that was added. diff --git a/app/Events/Metric/MetricWasRemovedEvent.php b/app/Events/Metric/MetricWasRemovedEvent.php index bd78e43d..abbff8c0 100644 --- a/app/Events/Metric/MetricWasRemovedEvent.php +++ b/app/Events/Metric/MetricWasRemovedEvent.php @@ -13,7 +13,7 @@ namespace CachetHQ\Cachet\Events\Metric; use CachetHQ\Cachet\Models\Metric; -class MetricWasRemovedEvent implements MetricEventInterface +final class MetricWasRemovedEvent implements MetricEventInterface { /** * The metric that was removed. diff --git a/app/Events/Metric/MetricWasUpdatedEvent.php b/app/Events/Metric/MetricWasUpdatedEvent.php index 8dc1de20..b3343aad 100644 --- a/app/Events/Metric/MetricWasUpdatedEvent.php +++ b/app/Events/Metric/MetricWasUpdatedEvent.php @@ -13,7 +13,7 @@ namespace CachetHQ\Cachet\Events\Metric; use CachetHQ\Cachet\Models\Metric; -class MetricWasUpdatedEvent implements MetricEventInterface +final class MetricWasUpdatedEvent implements MetricEventInterface { /** * The metric that was updated. diff --git a/app/Events/Subscriber/SubscriberHasSubscribedEvent.php b/app/Events/Subscriber/SubscriberHasSubscribedEvent.php index 26cd90f7..964f7f61 100644 --- a/app/Events/Subscriber/SubscriberHasSubscribedEvent.php +++ b/app/Events/Subscriber/SubscriberHasSubscribedEvent.php @@ -13,7 +13,7 @@ namespace CachetHQ\Cachet\Events\Subscriber; use CachetHQ\Cachet\Models\Subscriber; -class SubscriberHasSubscribedEvent implements SubscriberEventInterface +final class SubscriberHasSubscribedEvent implements SubscriberEventInterface { /** * The subscriber who has subscribed. diff --git a/app/Events/Subscriber/SubscriberHasUnsubscribedEvent.php b/app/Events/Subscriber/SubscriberHasUnsubscribedEvent.php index bb428577..77beed3d 100644 --- a/app/Events/Subscriber/SubscriberHasUnsubscribedEvent.php +++ b/app/Events/Subscriber/SubscriberHasUnsubscribedEvent.php @@ -13,7 +13,7 @@ namespace CachetHQ\Cachet\Events\Subscriber; use CachetHQ\Cachet\Models\Subscriber; -class SubscriberHasUnsubscribedEvent implements SubscriberEventInterface +final class SubscriberHasUnsubscribedEvent implements SubscriberEventInterface { /** * The subscriber who has unsubscribed. diff --git a/app/Events/Subscriber/SubscriberHasVerifiedEvent.php b/app/Events/Subscriber/SubscriberHasVerifiedEvent.php index a99fdb76..08644a41 100644 --- a/app/Events/Subscriber/SubscriberHasVerifiedEvent.php +++ b/app/Events/Subscriber/SubscriberHasVerifiedEvent.php @@ -13,7 +13,7 @@ namespace CachetHQ\Cachet\Events\Subscriber; use CachetHQ\Cachet\Models\Subscriber; -class SubscriberHasVerifiedEvent implements SubscriberEventInterface +final class SubscriberHasVerifiedEvent implements SubscriberEventInterface { /** * The subscriber who has verified. diff --git a/app/Events/User/UserWasInvitedEvent.php b/app/Events/User/UserWasInvitedEvent.php index 2671c10d..bf16b6df 100644 --- a/app/Events/User/UserWasInvitedEvent.php +++ b/app/Events/User/UserWasInvitedEvent.php @@ -13,7 +13,7 @@ namespace CachetHQ\Cachet\Events\User; use CachetHQ\Cachet\Models\Invite; -final class UserWasInvitedEvent +final class UserWasInvitedEvent implements UserEventInterface { /** * The invite that has been added. From db9a6cd8f826c8f10e79357889e9c65072856bff Mon Sep 17 00:00:00 2001 From: James Brooks Date: Fri, 25 Dec 2015 16:05:12 +0000 Subject: [PATCH 2/8] Register more of the events --- .../Providers/EventServiceProvider.php | 36 +++++++++++++++++++ 1 file changed, 36 insertions(+) diff --git a/app/Foundation/Providers/EventServiceProvider.php b/app/Foundation/Providers/EventServiceProvider.php index 19bc687a..544825f0 100644 --- a/app/Foundation/Providers/EventServiceProvider.php +++ b/app/Foundation/Providers/EventServiceProvider.php @@ -21,6 +21,42 @@ class EventServiceProvider extends ServiceProvider * @var array */ protected $listen = [ + 'CachetHQ\Cachet\Events\Component\ComponentWasAddedEvent' => [ + // + ], + 'CachetHQ\Cachet\Events\Component\ComponentWasRemovedEvent' => [ + // + ], + 'CachetHQ\Cachet\Events\Component\ComponentWasUpdatedEvent' => [ + // + ], + 'CachetHQ\Cachet\Events\ComponentGroup\ComponentGroupWasAddedEvent' => [ + // + ], + 'CachetHQ\Cachet\Events\ComponentGroup\ComponentGroupWasRemovedEvent' => [ + // + ], + 'CachetHQ\Cachet\Events\ComponentGroup\ComponentGroupWasUpdatedEvent' => [ + // + ], + 'CachetHQ\Cachet\Events\Metric\MetricWasAddedEvent' => [ + // + ], + 'CachetHQ\Cachet\Events\Metric\MetricWasRemovedEvent' => [ + // + ], + 'CachetHQ\Cachet\Events\Metric\MetricWasUpdatedEvent' => [ + // + ], + 'CachetHQ\Cachet\Events\Metric\MetricPointWasAddedEvent' => [ + // + ], + 'CachetHQ\Cachet\Events\Metric\MetricPointWasRemovedEvent' => [ + // + ], + 'CachetHQ\Cachet\Events\Metric\MetricPointWasUpdatedEvent' => [ + // + ], 'CachetHQ\Cachet\Events\Incident\IncidentWasReportedEvent' => [ 'CachetHQ\Cachet\Handlers\Events\Incident\SendIncidentEmailNotificationHandler', ], From f71e9c0cc59eb6a3f1c0b0381f57985403a3adc3 Mon Sep 17 00:00:00 2001 From: James Brooks Date: Fri, 25 Dec 2015 16:07:28 +0000 Subject: [PATCH 3/8] Fix ordering of event listeners --- .../Providers/EventServiceProvider.php | 32 +++++++++---------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/app/Foundation/Providers/EventServiceProvider.php b/app/Foundation/Providers/EventServiceProvider.php index 544825f0..e7ab2010 100644 --- a/app/Foundation/Providers/EventServiceProvider.php +++ b/app/Foundation/Providers/EventServiceProvider.php @@ -21,15 +21,6 @@ class EventServiceProvider extends ServiceProvider * @var array */ protected $listen = [ - 'CachetHQ\Cachet\Events\Component\ComponentWasAddedEvent' => [ - // - ], - 'CachetHQ\Cachet\Events\Component\ComponentWasRemovedEvent' => [ - // - ], - 'CachetHQ\Cachet\Events\Component\ComponentWasUpdatedEvent' => [ - // - ], 'CachetHQ\Cachet\Events\ComponentGroup\ComponentGroupWasAddedEvent' => [ // ], @@ -39,15 +30,21 @@ class EventServiceProvider extends ServiceProvider 'CachetHQ\Cachet\Events\ComponentGroup\ComponentGroupWasUpdatedEvent' => [ // ], - 'CachetHQ\Cachet\Events\Metric\MetricWasAddedEvent' => [ + 'CachetHQ\Cachet\Events\Component\ComponentWasAddedEvent' => [ // ], - 'CachetHQ\Cachet\Events\Metric\MetricWasRemovedEvent' => [ + 'CachetHQ\Cachet\Events\Component\ComponentWasRemovedEvent' => [ // ], - 'CachetHQ\Cachet\Events\Metric\MetricWasUpdatedEvent' => [ + 'CachetHQ\Cachet\Events\Component\ComponentWasUpdatedEvent' => [ // ], + 'CachetHQ\Cachet\Events\Incident\IncidentWasReportedEvent' => [ + 'CachetHQ\Cachet\Handlers\Events\Incident\SendIncidentEmailNotificationHandler', + ], + 'CachetHQ\Cachet\Events\Incident\MaintenanceWasScheduledEvent' => [ + 'CachetHQ\Cachet\Handlers\Events\Incident\SendMaintenanceEmailNotificationHandler', + ], 'CachetHQ\Cachet\Events\Metric\MetricPointWasAddedEvent' => [ // ], @@ -57,11 +54,14 @@ class EventServiceProvider extends ServiceProvider 'CachetHQ\Cachet\Events\Metric\MetricPointWasUpdatedEvent' => [ // ], - 'CachetHQ\Cachet\Events\Incident\IncidentWasReportedEvent' => [ - 'CachetHQ\Cachet\Handlers\Events\Incident\SendIncidentEmailNotificationHandler', + 'CachetHQ\Cachet\Events\Metric\MetricWasAddedEvent' => [ + // ], - 'CachetHQ\Cachet\Events\Incident\MaintenanceWasScheduledEvent' => [ - 'CachetHQ\Cachet\Handlers\Events\Incident\SendMaintenanceEmailNotificationHandler', + 'CachetHQ\Cachet\Events\Metric\MetricWasRemovedEvent' => [ + // + ], + 'CachetHQ\Cachet\Events\Metric\MetricWasUpdatedEvent' => [ + // ], 'CachetHQ\Cachet\Events\Subscriber\SubscriberHasSubscribedEvent' => [ 'CachetHQ\Cachet\Handlers\Events\Subscriber\SendSubscriberVerificationEmailHandler', From 68d5a5c29e0952b4b1e74429b4dc1b1946c62cb2 Mon Sep 17 00:00:00 2001 From: James Brooks Date: Fri, 25 Dec 2015 16:10:38 +0000 Subject: [PATCH 4/8] Started working on event tests --- .../AbstractComponentEventTestCase.php | 26 ++++++++++++++++ .../Component/ComponentWasAddedEventTest.php | 31 +++++++++++++++++++ .../ComponentWasRemovedEventTest.php | 31 +++++++++++++++++++ .../ComponentWasUpdatedEventTest.php | 31 +++++++++++++++++++ .../AbstractComponentGroupEventTestCase.php | 26 ++++++++++++++++ .../ComponentGroupWasAddedTest.php | 31 +++++++++++++++++++ .../ComponentGroupWasRemovedEventTest.php | 31 +++++++++++++++++++ .../ComponentGroupWasUpdatedEventTest.php | 31 +++++++++++++++++++ .../AbstractIncidentEventTestCase.php | 26 ++++++++++++++++ .../Invite/AbstractInviteEventTestCase.php | 26 ++++++++++++++++ .../Metric/AbstractMetricEventTestCase.php | 26 ++++++++++++++++ .../Events/Metric/MetricWasAddedEventTest.php | 31 +++++++++++++++++++ .../Metric/MetricWasRemovedEventTest.php | 31 +++++++++++++++++++ .../Metric/MetricWasUpdatedEventTest.php | 31 +++++++++++++++++++ .../AbstractSubscriberEventTestCase.php | 26 ++++++++++++++++ 15 files changed, 435 insertions(+) create mode 100644 tests/Events/Component/AbstractComponentEventTestCase.php create mode 100644 tests/Events/Component/ComponentWasAddedEventTest.php create mode 100644 tests/Events/Component/ComponentWasRemovedEventTest.php create mode 100644 tests/Events/Component/ComponentWasUpdatedEventTest.php create mode 100644 tests/Events/ComponentGroup/AbstractComponentGroupEventTestCase.php create mode 100644 tests/Events/ComponentGroup/ComponentGroupWasAddedTest.php create mode 100644 tests/Events/ComponentGroup/ComponentGroupWasRemovedEventTest.php create mode 100644 tests/Events/ComponentGroup/ComponentGroupWasUpdatedEventTest.php create mode 100644 tests/Events/Incident/AbstractIncidentEventTestCase.php create mode 100644 tests/Events/Invite/AbstractInviteEventTestCase.php create mode 100644 tests/Events/Metric/AbstractMetricEventTestCase.php create mode 100644 tests/Events/Metric/MetricWasAddedEventTest.php create mode 100644 tests/Events/Metric/MetricWasRemovedEventTest.php create mode 100644 tests/Events/Metric/MetricWasUpdatedEventTest.php create mode 100644 tests/Events/Subscriber/AbstractSubscriberEventTestCase.php diff --git a/tests/Events/Component/AbstractComponentEventTestCase.php b/tests/Events/Component/AbstractComponentEventTestCase.php new file mode 100644 index 00000000..54ee9343 --- /dev/null +++ b/tests/Events/Component/AbstractComponentEventTestCase.php @@ -0,0 +1,26 @@ + new Component()]; + $object = new ComponentWasAddedEvent($params['component']); + + return compact('params', 'object'); + } +} diff --git a/tests/Events/Component/ComponentWasRemovedEventTest.php b/tests/Events/Component/ComponentWasRemovedEventTest.php new file mode 100644 index 00000000..de88abb0 --- /dev/null +++ b/tests/Events/Component/ComponentWasRemovedEventTest.php @@ -0,0 +1,31 @@ + new Component()]; + $object = new ComponentWasRemovedEvent($params['component']); + + return compact('params', 'object'); + } +} diff --git a/tests/Events/Component/ComponentWasUpdatedEventTest.php b/tests/Events/Component/ComponentWasUpdatedEventTest.php new file mode 100644 index 00000000..b1fa0c1d --- /dev/null +++ b/tests/Events/Component/ComponentWasUpdatedEventTest.php @@ -0,0 +1,31 @@ + new Component()]; + $object = new ComponentWasUpdatedEvent($params['component']); + + return compact('params', 'object'); + } +} diff --git a/tests/Events/ComponentGroup/AbstractComponentGroupEventTestCase.php b/tests/Events/ComponentGroup/AbstractComponentGroupEventTestCase.php new file mode 100644 index 00000000..c25d349c --- /dev/null +++ b/tests/Events/ComponentGroup/AbstractComponentGroupEventTestCase.php @@ -0,0 +1,26 @@ + new ComponentGroup()]; + $object = new ComponentGroupWasAddedEvent($params['group']); + + return compact('params', 'object'); + } +} diff --git a/tests/Events/ComponentGroup/ComponentGroupWasRemovedEventTest.php b/tests/Events/ComponentGroup/ComponentGroupWasRemovedEventTest.php new file mode 100644 index 00000000..7a0697b9 --- /dev/null +++ b/tests/Events/ComponentGroup/ComponentGroupWasRemovedEventTest.php @@ -0,0 +1,31 @@ + new ComponentGroup()]; + $object = new ComponentGroupWasRemovedEvent($params['group']); + + return compact('params', 'object'); + } +} diff --git a/tests/Events/ComponentGroup/ComponentGroupWasUpdatedEventTest.php b/tests/Events/ComponentGroup/ComponentGroupWasUpdatedEventTest.php new file mode 100644 index 00000000..e4159597 --- /dev/null +++ b/tests/Events/ComponentGroup/ComponentGroupWasUpdatedEventTest.php @@ -0,0 +1,31 @@ + new ComponentGroup()]; + $object = new ComponentGroupWasUpdatedEvent($params['group']); + + return compact('params', 'object'); + } +} diff --git a/tests/Events/Incident/AbstractIncidentEventTestCase.php b/tests/Events/Incident/AbstractIncidentEventTestCase.php new file mode 100644 index 00000000..def965a7 --- /dev/null +++ b/tests/Events/Incident/AbstractIncidentEventTestCase.php @@ -0,0 +1,26 @@ + new Metric()]; + $object = new MetricWasAddedEvent($params['metric']); + + return compact('params', 'object'); + } +} diff --git a/tests/Events/Metric/MetricWasRemovedEventTest.php b/tests/Events/Metric/MetricWasRemovedEventTest.php new file mode 100644 index 00000000..f019538f --- /dev/null +++ b/tests/Events/Metric/MetricWasRemovedEventTest.php @@ -0,0 +1,31 @@ + new Metric()]; + $object = new MetricWasRemovedEvent($params['metric']); + + return compact('params', 'object'); + } +} diff --git a/tests/Events/Metric/MetricWasUpdatedEventTest.php b/tests/Events/Metric/MetricWasUpdatedEventTest.php new file mode 100644 index 00000000..9ccb9d66 --- /dev/null +++ b/tests/Events/Metric/MetricWasUpdatedEventTest.php @@ -0,0 +1,31 @@ + new Metric()]; + $object = new MetricWasUpdatedEvent($params['metric']); + + return compact('params', 'object'); + } +} diff --git a/tests/Events/Subscriber/AbstractSubscriberEventTestCase.php b/tests/Events/Subscriber/AbstractSubscriberEventTestCase.php new file mode 100644 index 00000000..a776bd62 --- /dev/null +++ b/tests/Events/Subscriber/AbstractSubscriberEventTestCase.php @@ -0,0 +1,26 @@ + Date: Fri, 25 Dec 2015 11:10:54 -0500 Subject: [PATCH 5/8] Applied fixes from StyleCI --- tests/Events/ComponentGroup/ComponentGroupWasAddedTest.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/Events/ComponentGroup/ComponentGroupWasAddedTest.php b/tests/Events/ComponentGroup/ComponentGroupWasAddedTest.php index 3c09df27..a0de8c9f 100644 --- a/tests/Events/ComponentGroup/ComponentGroupWasAddedTest.php +++ b/tests/Events/ComponentGroup/ComponentGroupWasAddedTest.php @@ -14,7 +14,7 @@ namespace CachetHQ\Tests\Cachet\Events\ComponentGroup; use CachetHQ\Cachet\Events\ComponentGroup\ComponentGroupWasAddedEvent; use CachetHQ\Cachet\Models\ComponentGroup; -class ComponentGroupWasAddedEventTest extends AbstractComponentGroupEventTestCase +class ComponentGroupWasAddedTest extends AbstractComponentGroupEventTestCase { protected function objectHasHandlers() { From 0ba49b2a7c3070572a3bf851842d82af3ad3c02e Mon Sep 17 00:00:00 2001 From: James Brooks Date: Sat, 26 Dec 2015 09:33:39 +0000 Subject: [PATCH 6/8] Fix class name --- ...roupWasAddedTest.php => ComponentGroupWasAddedEventTest.php} | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) rename tests/Events/ComponentGroup/{ComponentGroupWasAddedTest.php => ComponentGroupWasAddedEventTest.php} (89%) diff --git a/tests/Events/ComponentGroup/ComponentGroupWasAddedTest.php b/tests/Events/ComponentGroup/ComponentGroupWasAddedEventTest.php similarity index 89% rename from tests/Events/ComponentGroup/ComponentGroupWasAddedTest.php rename to tests/Events/ComponentGroup/ComponentGroupWasAddedEventTest.php index a0de8c9f..3c09df27 100644 --- a/tests/Events/ComponentGroup/ComponentGroupWasAddedTest.php +++ b/tests/Events/ComponentGroup/ComponentGroupWasAddedEventTest.php @@ -14,7 +14,7 @@ namespace CachetHQ\Tests\Cachet\Events\ComponentGroup; use CachetHQ\Cachet\Events\ComponentGroup\ComponentGroupWasAddedEvent; use CachetHQ\Cachet\Models\ComponentGroup; -class ComponentGroupWasAddedTest extends AbstractComponentGroupEventTestCase +class ComponentGroupWasAddedEventTest extends AbstractComponentGroupEventTestCase { protected function objectHasHandlers() { From 06962c6dedba785619c02fd6c40e7d3f0c933ca2 Mon Sep 17 00:00:00 2001 From: James Brooks Date: Sat, 26 Dec 2015 09:42:47 +0000 Subject: [PATCH 7/8] Fix name of InviteWasClaimed event class --- .../Invite/{InviteWasClaimed.php => InviteWasClaimedEvent.php} | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) rename app/Events/Invite/{InviteWasClaimed.php => InviteWasClaimedEvent.php} (90%) diff --git a/app/Events/Invite/InviteWasClaimed.php b/app/Events/Invite/InviteWasClaimedEvent.php similarity index 90% rename from app/Events/Invite/InviteWasClaimed.php rename to app/Events/Invite/InviteWasClaimedEvent.php index 9c7dfcb3..77c562ab 100644 --- a/app/Events/Invite/InviteWasClaimed.php +++ b/app/Events/Invite/InviteWasClaimedEvent.php @@ -13,7 +13,7 @@ namespace CachetHQ\Cachet\Events\Invite; use CachetHQ\Cachet\Models\Invite; -final class InviteWasClaimed implements InviteEventInterface +final class InviteWasClaimedEvent implements InviteEventInterface { /** * The invite that has been claimed. From 751859461b846eaa51ecafe70ab47a49f851702d Mon Sep 17 00:00:00 2001 From: James Brooks Date: Sat, 26 Dec 2015 09:44:32 +0000 Subject: [PATCH 8/8] Finish event tests --- .../Providers/EventServiceProvider.php | 9 ++++++ .../Invite/InviteWasClaimedEventTest.php | 31 +++++++++++++++++++ .../SubscriberHasSubscribedEventTest.php | 31 +++++++++++++++++++ .../SubscriberHasUnsubscribedEventTest.php | 31 +++++++++++++++++++ .../SubscriberHasVerifiedEventTest.php | 31 +++++++++++++++++++ 5 files changed, 133 insertions(+) create mode 100644 tests/Events/Invite/InviteWasClaimedEventTest.php create mode 100644 tests/Events/Subscriber/SubscriberHasSubscribedEventTest.php create mode 100644 tests/Events/Subscriber/SubscriberHasUnsubscribedEventTest.php create mode 100644 tests/Events/Subscriber/SubscriberHasVerifiedEventTest.php diff --git a/app/Foundation/Providers/EventServiceProvider.php b/app/Foundation/Providers/EventServiceProvider.php index e7ab2010..e5597efb 100644 --- a/app/Foundation/Providers/EventServiceProvider.php +++ b/app/Foundation/Providers/EventServiceProvider.php @@ -45,6 +45,9 @@ class EventServiceProvider extends ServiceProvider 'CachetHQ\Cachet\Events\Incident\MaintenanceWasScheduledEvent' => [ 'CachetHQ\Cachet\Handlers\Events\Incident\SendMaintenanceEmailNotificationHandler', ], + 'CachetHQ\Cachet\Events\Invite\InviteWasClaimedEvent' => [ + // + ], 'CachetHQ\Cachet\Events\Metric\MetricPointWasAddedEvent' => [ // ], @@ -66,6 +69,12 @@ class EventServiceProvider extends ServiceProvider 'CachetHQ\Cachet\Events\Subscriber\SubscriberHasSubscribedEvent' => [ 'CachetHQ\Cachet\Handlers\Events\Subscriber\SendSubscriberVerificationEmailHandler', ], + 'CachetHQ\Cachet\Events\Subscriber\SubscriberHasUnsubscribedEvent' => [ + // + ], + 'CachetHQ\Cachet\Events\Subscriber\SubscriberHasVerifiedEvent' => [ + // + ], 'CachetHQ\Cachet\Events\User\UserWasAddedEvent' => [ // ], diff --git a/tests/Events/Invite/InviteWasClaimedEventTest.php b/tests/Events/Invite/InviteWasClaimedEventTest.php new file mode 100644 index 00000000..358c55e9 --- /dev/null +++ b/tests/Events/Invite/InviteWasClaimedEventTest.php @@ -0,0 +1,31 @@ + new Invite()]; + $object = new InviteWasClaimedEvent($params['invite']); + + return compact('params', 'object'); + } +} diff --git a/tests/Events/Subscriber/SubscriberHasSubscribedEventTest.php b/tests/Events/Subscriber/SubscriberHasSubscribedEventTest.php new file mode 100644 index 00000000..083ed8ab --- /dev/null +++ b/tests/Events/Subscriber/SubscriberHasSubscribedEventTest.php @@ -0,0 +1,31 @@ + new Subscriber()]; + $object = new SubscriberHasSubscribedEvent($params['subscriber']); + + return compact('params', 'object'); + } +} diff --git a/tests/Events/Subscriber/SubscriberHasUnsubscribedEventTest.php b/tests/Events/Subscriber/SubscriberHasUnsubscribedEventTest.php new file mode 100644 index 00000000..4f1f470c --- /dev/null +++ b/tests/Events/Subscriber/SubscriberHasUnsubscribedEventTest.php @@ -0,0 +1,31 @@ + new Subscriber()]; + $object = new SubscriberHasUnsubscribedEvent($params['subscriber']); + + return compact('params', 'object'); + } +} diff --git a/tests/Events/Subscriber/SubscriberHasVerifiedEventTest.php b/tests/Events/Subscriber/SubscriberHasVerifiedEventTest.php new file mode 100644 index 00000000..6486f2f9 --- /dev/null +++ b/tests/Events/Subscriber/SubscriberHasVerifiedEventTest.php @@ -0,0 +1,31 @@ + new Subscriber()]; + $object = new SubscriberHasVerifiedEvent($params['subscriber']); + + return compact('params', 'object'); + } +}