From 3a1042e6aecbc081ab6d03385283ed2bc440c01f Mon Sep 17 00:00:00 2001 From: Graham Campbell Date: Sat, 28 May 2016 16:19:17 +0100 Subject: [PATCH 1/2] Tweaked the metric repo binding --- app/Foundation/Providers/RepositoryServiceProvider.php | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/app/Foundation/Providers/RepositoryServiceProvider.php b/app/Foundation/Providers/RepositoryServiceProvider.php index 9061e9a3..8e5b00aa 100644 --- a/app/Foundation/Providers/RepositoryServiceProvider.php +++ b/app/Foundation/Providers/RepositoryServiceProvider.php @@ -37,7 +37,7 @@ class RepositoryServiceProvider extends ServiceProvider */ protected function registerMetricRepository() { - $this->app->singleton('cachet.metricrepository', function ($app) { + $this->app->singleton(MetricRepository::class, function ($app) { $dbDriver = $app['config']->get('database.default'); if ($dbDriver == 'mysql') { @@ -52,7 +52,5 @@ class RepositoryServiceProvider extends ServiceProvider return new MetricRepository($repository, $dates); }); - - $this->app->alias('cachet.metricrepository', MetricRepository::class); } } From 1c10cba5fc5e337e40cd9bba7e7bfe0f9c9bd469 Mon Sep 17 00:00:00 2001 From: Graham Campbell Date: Sat, 28 May 2016 16:19:33 +0100 Subject: [PATCH 2/2] Added more service provider tests --- .../Providers/AppServiceProviderTest.php | 12 ++++++ .../Providers/ComposerServiceProviderTest.php | 25 +++++++++++++ .../Providers/ConfigServiceProviderTest.php | 37 +++++++++++++++++++ .../Providers/ConsoleServiceProviderTest.php | 25 +++++++++++++ .../RepositoryServiceProviderTest.php | 6 +++ .../Providers/RouteServiceProviderTest.php | 25 +++++++++++++ 6 files changed, 130 insertions(+) create mode 100644 tests/Foundation/Providers/ComposerServiceProviderTest.php create mode 100644 tests/Foundation/Providers/ConfigServiceProviderTest.php create mode 100644 tests/Foundation/Providers/ConsoleServiceProviderTest.php create mode 100644 tests/Foundation/Providers/RouteServiceProviderTest.php diff --git a/tests/Foundation/Providers/AppServiceProviderTest.php b/tests/Foundation/Providers/AppServiceProviderTest.php index 5b59ae7b..4b6a6e58 100644 --- a/tests/Foundation/Providers/AppServiceProviderTest.php +++ b/tests/Foundation/Providers/AppServiceProviderTest.php @@ -12,6 +12,8 @@ namespace CachetHQ\Tests\Cachet\Foundation\Providers; use AltThree\TestBench\ServiceProviderTrait; +use CachetHQ\Cachet\Dates\DateFactory; +use CachetHQ\Cachet\GitHub\Release; use CachetHQ\Tests\Cachet\AbstractTestCase; /** @@ -22,4 +24,14 @@ use CachetHQ\Tests\Cachet\AbstractTestCase; class AppServiceProviderTest extends AbstractTestCase { use ServiceProviderTrait; + + public function testDateFactoryIsInjectable() + { + $this->assertIsInjectable(DateFactory::class); + } + + public function testReleaseIsInjectable() + { + $this->assertIsInjectable(Release::class); + } } diff --git a/tests/Foundation/Providers/ComposerServiceProviderTest.php b/tests/Foundation/Providers/ComposerServiceProviderTest.php new file mode 100644 index 00000000..8e4d11cf --- /dev/null +++ b/tests/Foundation/Providers/ComposerServiceProviderTest.php @@ -0,0 +1,25 @@ + + */ +class ComposerServiceProviderTest extends AbstractTestCase +{ + use ServiceProviderTrait; +} diff --git a/tests/Foundation/Providers/ConfigServiceProviderTest.php b/tests/Foundation/Providers/ConfigServiceProviderTest.php new file mode 100644 index 00000000..45345d50 --- /dev/null +++ b/tests/Foundation/Providers/ConfigServiceProviderTest.php @@ -0,0 +1,37 @@ + + */ +class ConfigServiceProviderTest extends AbstractTestCase +{ + use ServiceProviderTrait; + + public function testCacheIsInjectable() + { + $this->assertIsInjectable(Cache::class); + } + + public function testRepositoryIsInjectable() + { + $this->assertIsInjectable(Repository::class); + } +} diff --git a/tests/Foundation/Providers/ConsoleServiceProviderTest.php b/tests/Foundation/Providers/ConsoleServiceProviderTest.php new file mode 100644 index 00000000..0050c8a4 --- /dev/null +++ b/tests/Foundation/Providers/ConsoleServiceProviderTest.php @@ -0,0 +1,25 @@ + + */ +class ConsoleServiceProviderTest extends AbstractTestCase +{ + use ServiceProviderTrait; +} diff --git a/tests/Foundation/Providers/RepositoryServiceProviderTest.php b/tests/Foundation/Providers/RepositoryServiceProviderTest.php index c989299f..585a7ab7 100644 --- a/tests/Foundation/Providers/RepositoryServiceProviderTest.php +++ b/tests/Foundation/Providers/RepositoryServiceProviderTest.php @@ -12,6 +12,7 @@ namespace CachetHQ\Tests\Cachet\Foundation\Providers; use AltThree\TestBench\ServiceProviderTrait; +use CachetHQ\Cachet\Repositories\Metric\MetricRepository; use CachetHQ\Tests\Cachet\AbstractTestCase; /** @@ -22,4 +23,9 @@ use CachetHQ\Tests\Cachet\AbstractTestCase; class RepositoryServiceProviderTest extends AbstractTestCase { use ServiceProviderTrait; + + public function testMetricRepositoryIsInjectable() + { + $this->assertIsInjectable(MetricRepository::class); + } } diff --git a/tests/Foundation/Providers/RouteServiceProviderTest.php b/tests/Foundation/Providers/RouteServiceProviderTest.php new file mode 100644 index 00000000..911c6f08 --- /dev/null +++ b/tests/Foundation/Providers/RouteServiceProviderTest.php @@ -0,0 +1,25 @@ + + */ +class RouteServiceProviderTest extends AbstractTestCase +{ + use ServiceProviderTrait; +}