From c064ece5f583ffe009f67de82279b36372fc111c Mon Sep 17 00:00:00 2001 From: Graham Campbell Date: Thu, 1 Jan 2015 14:30:54 +0000 Subject: [PATCH 01/12] Service provider refactoring --- app/config/app.php | 6 ++---- .../RepositoryServiceProvider.php | 2 +- .../RoutingServiceProvider.php | 2 +- 3 files changed, 4 insertions(+), 6 deletions(-) rename src/{Support/ServiceProviders => Providers}/RepositoryServiceProvider.php (93%) rename src/{Support/ServiceProviders => Providers}/RoutingServiceProvider.php (94%) diff --git a/app/config/app.php b/app/config/app.php index a182c155..be45956a 100644 --- a/app/config/app.php +++ b/app/config/app.php @@ -113,7 +113,6 @@ return [ 'Illuminate\Pagination\PaginationServiceProvider', 'Illuminate\Queue\QueueServiceProvider', 'Illuminate\Redis\RedisServiceProvider', - 'Illuminate\Remote\RemoteServiceProvider', 'Illuminate\Auth\Reminders\ReminderServiceProvider', 'Illuminate\Database\SeedServiceProvider', 'Illuminate\Session\SessionServiceProvider', @@ -127,8 +126,8 @@ return [ 'GrahamCampbell\Markdown\MarkdownServiceProvider', 'Thujohn\Rss\RssServiceProvider', - 'CachetHQ\Cachet\Support\ServiceProviders\RepositoryServiceProvider', - 'CachetHQ\Cachet\Support\ServiceProviders\RoutingServiceProvider', + 'CachetHQ\Cachet\Providers\RepositoryServiceProvider', + 'CachetHQ\Cachet\Providers\RoutingServiceProvider', ], @@ -192,7 +191,6 @@ return [ 'Seeder' => 'Illuminate\Database\Seeder', 'Session' => 'Illuminate\Support\Facades\Session', 'SoftDeletingTrait' => 'Illuminate\Database\Eloquent\SoftDeletingTrait', - 'SSH' => 'Illuminate\Support\Facades\SSH', 'Str' => 'Illuminate\Support\Str', 'URL' => 'Illuminate\Support\Facades\URL', 'Validator' => 'Illuminate\Support\Facades\Validator', diff --git a/src/Support/ServiceProviders/RepositoryServiceProvider.php b/src/Providers/RepositoryServiceProvider.php similarity index 93% rename from src/Support/ServiceProviders/RepositoryServiceProvider.php rename to src/Providers/RepositoryServiceProvider.php index c193b5d3..89166bd0 100644 --- a/src/Support/ServiceProviders/RepositoryServiceProvider.php +++ b/src/Providers/RepositoryServiceProvider.php @@ -1,6 +1,6 @@ Date: Thu, 1 Jan 2015 15:43:05 +0000 Subject: [PATCH 02/12] Fix seeder imports --- app/database/seeds/ComponentTableSeeder.php | 5 ++++- app/database/seeds/DatabaseSeeder.php | 5 ++++- app/database/seeds/IncidentTableSeeder.php | 5 ++++- app/database/seeds/SettingsTableSeeder.php | 5 ++++- 4 files changed, 16 insertions(+), 4 deletions(-) diff --git a/app/database/seeds/ComponentTableSeeder.php b/app/database/seeds/ComponentTableSeeder.php index 316f1b08..9bbe9d0d 100644 --- a/app/database/seeds/ComponentTableSeeder.php +++ b/app/database/seeds/ComponentTableSeeder.php @@ -1,5 +1,8 @@ call('UsersTableSeeder'); $this->call('SettingsTableSeeder'); diff --git a/app/database/seeds/IncidentTableSeeder.php b/app/database/seeds/IncidentTableSeeder.php index 28557cf1..902a81bb 100644 --- a/app/database/seeds/IncidentTableSeeder.php +++ b/app/database/seeds/IncidentTableSeeder.php @@ -1,5 +1,8 @@ Date: Thu, 1 Jan 2015 15:43:56 +0000 Subject: [PATCH 03/12] Added two other imports --- app/filters/LoginThrottlingFilter.php | 2 ++ app/models/Incident.php | 1 + 2 files changed, 3 insertions(+) diff --git a/app/filters/LoginThrottlingFilter.php b/app/filters/LoginThrottlingFilter.php index ae7447df..80b3dc86 100644 --- a/app/filters/LoginThrottlingFilter.php +++ b/app/filters/LoginThrottlingFilter.php @@ -1,5 +1,7 @@ Date: Thu, 1 Jan 2015 15:45:04 +0000 Subject: [PATCH 04/12] Refactored controllers --- app/routes/api.php | 6 +--- app/routes/app.php | 4 +-- app/routes/auth.php | 2 +- app/routes/dashboard.php | 2 +- .../Controllers}/AuthController.php | 22 +++++++++++---- .../Controllers}/DashAPIController.php | 27 ++++++++++-------- .../Controllers}/DashComponentController.php | 8 ++++++ .../Controllers}/DashIncidentController.php | 9 ++++++ .../Controllers}/DashSettingsController.php | 28 +++++++++++-------- .../Controllers}/DashUserController.php | 8 ++++++ .../Controllers}/DashboardController.php | 6 ++++ .../Controllers}/HomeController.php | 26 +++++------------ .../Controllers/RssController.php | 16 ++++++++--- .../Controllers}/SetupController.php | 17 +++++++++-- 14 files changed, 118 insertions(+), 63 deletions(-) rename {app/controllers => src/Controllers}/AuthController.php (60%) rename {app/controllers => src/Controllers}/DashAPIController.php (58%) rename {app/controllers => src/Controllers}/DashComponentController.php (91%) rename {app/controllers => src/Controllers}/DashIncidentController.php (89%) rename {app/controllers => src/Controllers}/DashSettingsController.php (90%) rename {app/controllers => src/Controllers}/DashUserController.php (71%) rename {app/controllers => src/Controllers}/DashboardController.php (88%) rename {app/controllers => src/Controllers}/HomeController.php (55%) rename app/controllers/RSSController.php => src/Controllers/RssController.php (72%) rename {app/controllers => src/Controllers}/SetupController.php (80%) diff --git a/app/routes/api.php b/app/routes/api.php index c2c7b272..3e04d802 100644 --- a/app/routes/api.php +++ b/app/routes/api.php @@ -1,10 +1,6 @@ 'v1', - 'namespace' => 'CachetHQ\Cachet\Controllers\Api', - 'after' => 'allowed_domains', -], function () { +Route::api(['after' => 'allowed_domains', 'namespace' => 'CachetHQ\Cachet\Controllers\Api', 'version' => 'v1'], function () { Route::get('components', 'ComponentController@getComponents'); Route::get('components/{id}', 'ComponentController@getComponent'); Route::get('components/{id}/incidents', 'ComponentController@getComponentIncidents'); diff --git a/app/routes/app.php b/app/routes/app.php index 943edb1e..8ca87ef8 100644 --- a/app/routes/app.php +++ b/app/routes/app.php @@ -1,7 +1,7 @@ 'has_setting:app_name'], function () { +Route::group(['before' => 'has_setting:app_name', 'namespace' => 'CachetHQ\Cachet\Controllers'], function () { Route::get('/', ['as' => 'status-page', 'uses' => 'HomeController@showIndex']); Route::get('/incident/{incident}', 'HomeController@showIncident'); }); @@ -11,4 +11,4 @@ Route::group(['before' => 'is_setup'], function () { Route::controller('/setup', 'SetupController'); }); -Route::get('/rss', 'RSSController@feedAction'); +Route::get('/rss', 'RssController@feedAction'); diff --git a/app/routes/auth.php b/app/routes/auth.php index 520a0d28..c4abf3c6 100644 --- a/app/routes/auth.php +++ b/app/routes/auth.php @@ -1,6 +1,6 @@ 'has_setting:app_name'], function () { +Route::group(['before' => 'has_setting:app_name', 'namespace' => 'CachetHQ\Cachet\Controllers'], function () { Route::get('/auth/login', ['before' => 'guest', 'as' => 'login', 'uses' => 'AuthController@showLogin']); Route::post('/auth/login', ['before' => 'guest|csrf|login_throttling', 'as' => 'logout', 'uses' => 'AuthController@postLogin']); }); diff --git a/app/routes/dashboard.php b/app/routes/dashboard.php index ce1061a1..96c8dc46 100644 --- a/app/routes/dashboard.php +++ b/app/routes/dashboard.php @@ -1,6 +1,6 @@ 'auth', 'prefix' => 'dashboard'], function () { +Route::group(['before' => 'auth', 'prefix' => 'dashboard', 'namespace' => 'CachetHQ\Cachet\Controllers'], function () { // Dashboard Route::get('/', ['as' => 'dashboard', 'uses' => 'DashboardController@showDashboard']); diff --git a/app/controllers/AuthController.php b/src/Controllers/AuthController.php similarity index 60% rename from app/controllers/AuthController.php rename to src/Controllers/AuthController.php index 688b4ccb..f6850893 100644 --- a/app/controllers/AuthController.php +++ b/src/Controllers/AuthController.php @@ -1,5 +1,15 @@ withInput(Input::except('password')) - ->with('error', 'Invalid email or password'); } + + Throttle::hit(Request::instance(), 10, 10); + + return Redirect::back() + ->withInput(Input::except('password')) + ->with('error', 'Invalid email or password'); } /** diff --git a/app/controllers/DashAPIController.php b/src/Controllers/DashAPIController.php similarity index 58% rename from app/controllers/DashAPIController.php rename to src/Controllers/DashAPIController.php index 39d5b1cb..f72ad5b5 100644 --- a/app/controllers/DashAPIController.php +++ b/src/Controllers/DashAPIController.php @@ -1,23 +1,30 @@ update($componentData)) { - return $component; - } else { - App::abort(500); + if (!$component->update(Input::except(['_token']))) { + throw new Exception('Failed to update the component.'); } + + return $component; } /** @@ -32,9 +39,7 @@ class DashAPIController extends Controller foreach ($componentData['component'] as $componentId => $order) { $component = Component::find($componentId); - $component->update([ - 'order' => $order, - ]); + $component->update(['order' => $order]); } return $componentData; diff --git a/app/controllers/DashComponentController.php b/src/Controllers/DashComponentController.php similarity index 91% rename from app/controllers/DashComponentController.php rename to src/Controllers/DashComponentController.php index 4ff98b75..d47ca7e1 100644 --- a/app/controllers/DashComponentController.php +++ b/src/Controllers/DashComponentController.php @@ -1,5 +1,13 @@ delete(); } - unset($settings['remove-banner']); - if (Input::hasFile('app_banner')) { $file = Input::file('app_banner'); // Image Validation. // Image size in bytes. $maxSize = $file->getMaxFilesize(); + if ($file->getSize() > $maxSize) { return Redirect::back()->withErrorMessage('You need to upload an image that is less than '.$maxSize.'.'); - } elseif (!$file->isValid() || $file->getError()) { + } + + if (!$file->isValid() || $file->getError()) { return Redirect::back()->withErrorMessage($file->getErrorMessage()); - } elseif (strpos($file->getMimeType(), 'image/') !== 0) { + } + + if (strpos($file->getMimeType(), 'image/') !== 0) { return Redirect::back()->withErrorMessage('Only images may be uploaded.'); } @@ -144,10 +152,8 @@ class DashSettingsController extends Controller ]); } - unset($settings['app_banner']); - try { - foreach ($settings as $settingName => $settingValue) { + foreach (Input::except(['app_banner', 'remove-banner']) as $settingName => $settingValue) { $setting = Setting::firstOrCreate([ 'name' => $settingName, ])->update([ diff --git a/app/controllers/DashUserController.php b/src/Controllers/DashUserController.php similarity index 71% rename from app/controllers/DashUserController.php rename to src/Controllers/DashUserController.php index 0c09ca8a..ad4c30c8 100644 --- a/app/controllers/DashUserController.php +++ b/src/Controllers/DashUserController.php @@ -1,5 +1,13 @@ component = $component; - } - /** * Returns the rendered Blade templates. * diff --git a/app/controllers/RSSController.php b/src/Controllers/RssController.php similarity index 72% rename from app/controllers/RSSController.php rename to src/Controllers/RssController.php index 83188dc4..a6c99fe3 100644 --- a/app/controllers/RSSController.php +++ b/src/Controllers/RssController.php @@ -1,6 +1,14 @@ channel([ - 'title' => Setting::get('app_name'), + 'title' => Setting::get('app_name'), 'description' => 'Status Feed', - 'link' => Setting::get('app_domain'), + 'link' => Setting::get('app_domain'), ]); Incident::get()->map(function ($incident) use ($feed) { diff --git a/app/controllers/SetupController.php b/src/Controllers/SetupController.php similarity index 80% rename from app/controllers/SetupController.php rename to src/Controllers/SetupController.php index a1d8b0a7..bc355e76 100644 --- a/app/controllers/SetupController.php +++ b/src/Controllers/SetupController.php @@ -1,5 +1,16 @@ $userDetails['username'], 'email' => $userDetails['email'], @@ -59,8 +70,8 @@ class SetupController extends Controller $settings = array_get($postData, 'settings'); foreach ($settings as $settingName => $settingValue) { - $setting = new Setting(); - $setting->name = $settingName; + $setting = new Setting(); + $setting->name = $settingName; $setting->value = $settingValue; $setting->save(); } From 8d417baa8b27f367e2cdb92ff482ceab0f8c8c49 Mon Sep 17 00:00:00 2001 From: Graham Campbell Date: Thu, 1 Jan 2015 15:46:07 +0000 Subject: [PATCH 05/12] Cleanup aliases --- app/config/app.php | 12 +----------- app/views/partials/incident.blade.php | 2 +- 2 files changed, 2 insertions(+), 12 deletions(-) diff --git a/app/config/app.php b/app/config/app.php index be45956a..f93cf6a3 100644 --- a/app/config/app.php +++ b/app/config/app.php @@ -157,19 +157,16 @@ return [ 'aliases' => [ + 'API' => 'Dingo\Api\Facade\API', 'App' => 'Illuminate\Support\Facades\App', 'Artisan' => 'Illuminate\Support\Facades\Artisan', 'Auth' => 'Illuminate\Support\Facades\Auth', 'Blade' => 'Illuminate\Support\Facades\Blade', 'Cache' => 'Illuminate\Support\Facades\Cache', - 'Carbon' => 'Carbon\Carbon', - 'ClassLoader' => 'Illuminate\Support\ClassLoader', 'Config' => 'Illuminate\Support\Facades\Config', - 'Controller' => 'Illuminate\Routing\Controller', 'Cookie' => 'Illuminate\Support\Facades\Cookie', 'Crypt' => 'Illuminate\Support\Facades\Crypt', 'DB' => 'Illuminate\Support\Facades\DB', - 'Eloquent' => 'Illuminate\Database\Eloquent\Model', 'Event' => 'Illuminate\Support\Facades\Event', 'File' => 'Illuminate\Support\Facades\File', 'Form' => 'Illuminate\Support\Facades\Form', @@ -188,19 +185,12 @@ return [ 'Response' => 'Illuminate\Support\Facades\Response', 'Route' => 'Illuminate\Support\Facades\Route', 'Schema' => 'Illuminate\Support\Facades\Schema', - 'Seeder' => 'Illuminate\Database\Seeder', 'Session' => 'Illuminate\Support\Facades\Session', - 'SoftDeletingTrait' => 'Illuminate\Database\Eloquent\SoftDeletingTrait', 'Str' => 'Illuminate\Support\Str', 'URL' => 'Illuminate\Support\Facades\URL', 'Validator' => 'Illuminate\Support\Facades\Validator', 'View' => 'Illuminate\Support\Facades\View', - 'API' => 'Dingo\Api\Facade\API', - 'Throttle' => 'GrahamCampbell\Throttle\Facades\Throttle', - 'Markdown' => 'GrahamCampbell\Markdown\Facades\Markdown', - 'RSS' => 'Thujohn\Rss\RssFacade', - ], ]; diff --git a/app/views/partials/incident.blade.php b/app/views/partials/incident.blade.php index ce2b8f44..597d980a 100644 --- a/app/views/partials/incident.blade.php +++ b/app/views/partials/incident.blade.php @@ -1,5 +1,5 @@ subDays($i); + $incidentDate = Carbon\Carbon::now()->subDays($i); $incidents = Incident::whereBetween('created_at', [ $incidentDate->format('Y-m-d') . ' 00:00:00', $incidentDate->format('Y-m-d') . ' 23:59:59', From c38fdbc1d4db7637365b72e613d3f1821ce8b367 Mon Sep 17 00:00:00 2001 From: Graham Campbell Date: Thu, 1 Jan 2015 15:46:26 +0000 Subject: [PATCH 06/12] Fixed class loading --- app/start/global.php | 22 ---------------------- bootstrap/autoload.php | 13 ------------- composer.json | 1 - 3 files changed, 36 deletions(-) diff --git a/app/start/global.php b/app/start/global.php index c90d72c8..aa63d7af 100644 --- a/app/start/global.php +++ b/app/start/global.php @@ -1,27 +1,5 @@ Date: Thu, 1 Jan 2015 15:46:36 +0000 Subject: [PATCH 07/12] Updated the coverage config --- phpunit.xml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/phpunit.xml b/phpunit.xml index b12cc839..b60b43d4 100644 --- a/phpunit.xml +++ b/phpunit.xml @@ -20,8 +20,7 @@ - ./app/CachetHQ - ./app/controllers + ./src ./app/filters ./app/models From 598b487605b9b30cdf6871de01821353cc46ddad Mon Sep 17 00:00:00 2001 From: Graham Campbell Date: Thu, 1 Jan 2015 15:50:57 +0000 Subject: [PATCH 08/12] Removed the workbench functionality --- .gitignore | 1 - app/config/app.php | 1 - app/config/workbench.php | 31 ------------------------------- bootstrap/autoload.php | 15 --------------- 4 files changed, 48 deletions(-) delete mode 100644 app/config/workbench.php diff --git a/.gitignore b/.gitignore index 44c43bb6..290dae62 100644 --- a/.gitignore +++ b/.gitignore @@ -1,7 +1,6 @@ # Laravel /bootstrap/compiled.php /vendor -/workbench # Configuration .env.*.php diff --git a/app/config/app.php b/app/config/app.php index f93cf6a3..15f6db4b 100644 --- a/app/config/app.php +++ b/app/config/app.php @@ -119,7 +119,6 @@ return [ 'Illuminate\Translation\TranslationServiceProvider', 'Illuminate\Validation\ValidationServiceProvider', 'Illuminate\View\ViewServiceProvider', - 'Illuminate\Workbench\WorkbenchServiceProvider', 'Dingo\Api\Provider\ApiServiceProvider', 'GrahamCampbell\Throttle\ThrottleServiceProvider', diff --git a/app/config/workbench.php b/app/config/workbench.php deleted file mode 100644 index 735a7949..00000000 --- a/app/config/workbench.php +++ /dev/null @@ -1,31 +0,0 @@ - '', - - /* - |-------------------------------------------------------------------------- - | Workbench Author E-Mail Address - |-------------------------------------------------------------------------- - | - | Like the option above, your e-mail address is used when generating new - | workbench packages. The e-mail is placed in your composer.json file - | automatically after the package is created by the workbench tool. - | - */ - - 'email' => '', - -]; diff --git a/bootstrap/autoload.php b/bootstrap/autoload.php index 27d0835a..3514286c 100644 --- a/bootstrap/autoload.php +++ b/bootstrap/autoload.php @@ -43,18 +43,3 @@ if (file_exists($compiled = __DIR__.'/compiled.php')) { */ Patchwork\Utf8\Bootup::initMbstring(); - -/* -|-------------------------------------------------------------------------- -| Register The Workbench Loaders -|-------------------------------------------------------------------------- -| -| The Laravel workbench provides a convenient place to develop packages -| when working locally. However we will need to load in the Composer -| auto-load files for the packages so that these can be used here. -| -*/ - -if (is_dir($workbench = __DIR__.'/../workbench')) { - Illuminate\Workbench\Starter::start($workbench); -} From fd022f141377d6c5a98f030b1de19e36cc92edc5 Mon Sep 17 00:00:00 2001 From: Graham Campbell Date: Thu, 1 Jan 2015 15:51:19 +0000 Subject: [PATCH 09/12] Cleanup autoloading --- composer.json | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/composer.json b/composer.json index 69dcc915..84844031 100644 --- a/composer.json +++ b/composer.json @@ -27,16 +27,20 @@ }, "autoload": { "classmap": [ - "app/models", "app/database/migrations", "app/database/seeds", - "app/tests/TestCase.php", - "app/filters" + "app/filters", + "app/models" ], "psr-4": { "CachetHQ\\Cachet\\": "src/" } }, + "autoload-dev": { + "classmap": [ + "app/tests/TestCase.php", + ] + }, "extra": { "paas": { "document-root": "public", From 860d5e8cbe78d5611192f6f8e6e014e9304b22f9 Mon Sep 17 00:00:00 2001 From: Graham Campbell Date: Thu, 1 Jan 2015 15:53:18 +0000 Subject: [PATCH 10/12] Minor fixes --- composer.json | 2 +- src/Controllers/RssController.php | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/composer.json b/composer.json index 84844031..1fb54ee4 100644 --- a/composer.json +++ b/composer.json @@ -38,7 +38,7 @@ }, "autoload-dev": { "classmap": [ - "app/tests/TestCase.php", + "app/tests/TestCase.php" ] }, "extra": { diff --git a/src/Controllers/RssController.php b/src/Controllers/RssController.php index a6c99fe3..d96cbe03 100644 --- a/src/Controllers/RssController.php +++ b/src/Controllers/RssController.php @@ -19,9 +19,9 @@ class RssController extends Controller { $feed = RssFacade::feed('2.0', 'UTF-8'); $feed->channel([ - 'title' => Setting::get('app_name'), + 'title' => Setting::get('app_name'), 'description' => 'Status Feed', - 'link' => Setting::get('app_domain'), + 'link' => Setting::get('app_domain'), ]); Incident::get()->map(function ($incident) use ($feed) { From a1e91be91ce6f403e22c1defedf4fa499893e55d Mon Sep 17 00:00:00 2001 From: Graham Campbell Date: Thu, 1 Jan 2015 16:00:19 +0000 Subject: [PATCH 11/12] Fixed seeding --- app/database/seeds/ComponentTableSeeder.php | 2 +- app/database/seeds/DatabaseSeeder.php | 2 +- app/database/seeds/IncidentTableSeeder.php | 2 +- app/database/seeds/SettingsTableSeeder.php | 2 +- app/database/seeds/UsersTableSeeder.php | 7 +++++-- 5 files changed, 9 insertions(+), 6 deletions(-) diff --git a/app/database/seeds/ComponentTableSeeder.php b/app/database/seeds/ComponentTableSeeder.php index 9bbe9d0d..d65eb63b 100644 --- a/app/database/seeds/ComponentTableSeeder.php +++ b/app/database/seeds/ComponentTableSeeder.php @@ -6,7 +6,7 @@ use Illuminate\Database\Seeder; class ComponentTableSeeder extends Seeder { /** - * Run the database seeds. + * Run the database seeding. * * @return void */ diff --git a/app/database/seeds/DatabaseSeeder.php b/app/database/seeds/DatabaseSeeder.php index 5fc4ceeb..247933ae 100644 --- a/app/database/seeds/DatabaseSeeder.php +++ b/app/database/seeds/DatabaseSeeder.php @@ -6,7 +6,7 @@ use Illuminate\Database\Seeder; class DatabaseSeeder extends Seeder { /** - * Run the database seeds. + * Run the database seeding. * * @return void */ diff --git a/app/database/seeds/IncidentTableSeeder.php b/app/database/seeds/IncidentTableSeeder.php index 902a81bb..33963d87 100644 --- a/app/database/seeds/IncidentTableSeeder.php +++ b/app/database/seeds/IncidentTableSeeder.php @@ -6,7 +6,7 @@ use Illuminate\Database\Seeder; class IncidentTableSeeder extends Seeder { /** - * Run the database seeds. + * Run the database seeding. * * @return void */ diff --git a/app/database/seeds/SettingsTableSeeder.php b/app/database/seeds/SettingsTableSeeder.php index 8071413c..27b458de 100644 --- a/app/database/seeds/SettingsTableSeeder.php +++ b/app/database/seeds/SettingsTableSeeder.php @@ -6,7 +6,7 @@ use Illuminate\Database\Seeder; class SettingsTableSeeder extends Seeder { /** - * Run the database seeds. + * Run the database seeding. * * @return void */ diff --git a/app/database/seeds/UsersTableSeeder.php b/app/database/seeds/UsersTableSeeder.php index fe2d772b..142a23dc 100644 --- a/app/database/seeds/UsersTableSeeder.php +++ b/app/database/seeds/UsersTableSeeder.php @@ -1,15 +1,18 @@ Date: Thu, 1 Jan 2015 16:18:24 +0000 Subject: [PATCH 12/12] Fixes --- app/routes/app.php | 6 ++++-- app/routes/auth.php | 4 +++- composer.lock | 2 +- src/Controllers/AuthController.php | 4 ++-- src/Controllers/DashAPIController.php | 4 ++-- src/Controllers/DashComponentController.php | 4 ++-- src/Controllers/DashIncidentController.php | 4 ++-- src/Controllers/DashSettingsController.php | 4 ++-- src/Controllers/DashUserController.php | 4 ++-- src/Controllers/DashboardController.php | 2 +- src/Controllers/HomeController.php | 4 ++-- src/Controllers/RssController.php | 4 ++-- src/Controllers/SetupController.php | 4 ++-- 13 files changed, 27 insertions(+), 23 deletions(-) diff --git a/app/routes/app.php b/app/routes/app.php index 8ca87ef8..0705560c 100644 --- a/app/routes/app.php +++ b/app/routes/app.php @@ -7,8 +7,10 @@ Route::group(['before' => 'has_setting:app_name', 'namespace' => 'CachetHQ\Cache }); // Setup route. -Route::group(['before' => 'is_setup'], function () { +Route::group(['before' => 'is_setup', 'namespace' => 'CachetHQ\Cachet\Controllers'], function () { Route::controller('/setup', 'SetupController'); }); -Route::get('/rss', 'RssController@feedAction'); +Route::group(['namespace' => 'CachetHQ\Cachet\Controllers'], function () { + Route::get('/rss', 'RssController@feedAction'); +}); diff --git a/app/routes/auth.php b/app/routes/auth.php index c4abf3c6..bc5eb71e 100644 --- a/app/routes/auth.php +++ b/app/routes/auth.php @@ -5,4 +5,6 @@ Route::group(['before' => 'has_setting:app_name', 'namespace' => 'CachetHQ\Cache Route::post('/auth/login', ['before' => 'guest|csrf|login_throttling', 'as' => 'logout', 'uses' => 'AuthController@postLogin']); }); -Route::get('/auth/logout', ['before' => 'auth', 'as' => 'logout', 'uses' => 'AuthController@logoutAction']); +Route::group(['before' => 'auth', 'namespace' => 'CachetHQ\Cachet\Controllers'], function () { + Route::get('/auth/logout', ['as' => 'logout', 'uses' => 'AuthController@logoutAction']); +}); diff --git a/composer.lock b/composer.lock index ebe05723..435b5478 100644 --- a/composer.lock +++ b/composer.lock @@ -4,7 +4,7 @@ "Read more about it at http://getcomposer.org/doc/01-basic-usage.md#composer-lock-the-lock-file", "This file is @generated automatically" ], - "hash": "44248db4d4bba4ff38d7f3aef78acc79", + "hash": "af0ee6e5bc07e350732bc7c907e3b2ae", "packages": [ { "name": "classpreloader/classpreloader", diff --git a/src/Controllers/AuthController.php b/src/Controllers/AuthController.php index f6850893..65b21848 100644 --- a/src/Controllers/AuthController.php +++ b/src/Controllers/AuthController.php @@ -1,13 +1,13 @@