From e21918c81e5c3db5af7fac7591a9c012da6291ae Mon Sep 17 00:00:00 2001 From: James Brooks Date: Sat, 26 Jan 2019 10:12:22 +0000 Subject: [PATCH 1/2] Remove duplicate order statement. Fixes #3418 --- app/Presenters/IncidentPresenter.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/Presenters/IncidentPresenter.php b/app/Presenters/IncidentPresenter.php index 139860cb..0a8e8a65 100644 --- a/app/Presenters/IncidentPresenter.php +++ b/app/Presenters/IncidentPresenter.php @@ -256,7 +256,7 @@ class IncidentPresenter extends BasePresenter implements Arrayable public function latest() { if (is_bool($this->latest)) { - $this->latest = $this->wrappedObject->updates()->orderBy('created_at', 'desc')->first(); + $this->latest = $this->wrappedObject->updates()->first(); } return $this->latest; From 0ae510fdf0b02352d7b4a62e2fcb9e2e6cfe475c Mon Sep 17 00:00:00 2001 From: James Brooks Date: Sat, 26 Jan 2019 15:00:42 +0000 Subject: [PATCH 2/2] Fix other duplicate order by statements --- app/Composers/ComponentsComposer.php | 2 +- resources/views/partials/components.blade.php | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/app/Composers/ComponentsComposer.php b/app/Composers/ComponentsComposer.php index 7e62715c..1fac9423 100644 --- a/app/Composers/ComponentsComposer.php +++ b/app/Composers/ComponentsComposer.php @@ -53,7 +53,7 @@ class ComponentsComposer public function compose(View $view) { $componentGroups = $this->getVisibleGroupedComponents(); - $ungroupedComponents = Component::ungrouped()->get(); + $ungroupedComponents = Component::ungrouped()->orderBy('status', 'desc')->get(); $view->withComponentGroups($componentGroups) ->withUngroupedComponents($ungroupedComponents); diff --git a/resources/views/partials/components.blade.php b/resources/views/partials/components.blade.php index 2fd869af..c35143a9 100644 --- a/resources/views/partials/components.blade.php +++ b/resources/views/partials/components.blade.php @@ -12,7 +12,7 @@
- @each('partials.component', $componentGroup->enabled_components()->orderBy('order')->get(), 'component') + @each('partials.component', $componentGroup->enabled_components, 'component')
@endif @@ -25,7 +25,7 @@ {{ trans('cachet.components.group.other') }}
- +