From 8d1bdf2a84db380ec40f7bca0eaff82627da6c68 Mon Sep 17 00:00:00 2001 From: James Brooks Date: Mon, 18 Feb 2019 22:06:32 +0000 Subject: [PATCH] More UX and UI fixes --- resources/assets/js/cachet.js | 12 +++++------- resources/views/subscribe/manage.blade.php | 7 ++++++- 2 files changed, 11 insertions(+), 8 deletions(-) diff --git a/resources/assets/js/cachet.js b/resources/assets/js/cachet.js index f17e0d22..37871349 100644 --- a/resources/assets/js/cachet.js +++ b/resources/assets/js/cachet.js @@ -216,7 +216,9 @@ $(function () { $('input[name=remove_banner]').val('1'); }); - $('.group-name').on('click', function () { + $('.group-name').on('click', function (event) { + event.stopPropagation(); + var $this = $(this); $this.find('.group-toggle').toggleClass('ion-ios-minus-outline').toggleClass('ion-ios-plus-outline'); @@ -224,20 +226,16 @@ $(function () { $this.next('.group-items').toggleClass('hide'); }); - $('.select-group').on('click', function () { + $('.select-group').on('click', function (event) { var $parentGroup = $(this).closest('ul.list-group'); $parentGroup.find('input[type=checkbox]').prop('checked', true); - $parentGroup.find('.group-items').removeClass('hide') - $parentGroup.find('.group-toggle').addClass('ion-ios-minus-outline').removeClass('ion-ios-plus-outline'); event.stopPropagation(); return false; }); - $('.deselect-group').on('click', function () { + $('.deselect-group').on('click', function (event) { var $parentGroup = $(this).closest('ul.list-group'); $parentGroup.find('input[type=checkbox]').prop('checked', false); - $parentGroup.find('.group-items').addClass('hide'); - $parentGroup.find('.group-toggle').removeClass('ion-ios-minus-outline').addClass('ion-ios-plus-outline'); event.stopPropagation(); return false; }); diff --git a/resources/views/subscribe/manage.blade.php b/resources/views/subscribe/manage.blade.php index f4ae904f..1e14808c 100644 --- a/resources/views/subscribe/manage.blade.php +++ b/resources/views/subscribe/manage.blade.php @@ -41,9 +41,14 @@ @endforeach @if($ungroupedComponents->isNotEmpty()) -