From 3c46387dd83941bd3a9dfbab16d20bfd2d164df1 Mon Sep 17 00:00:00 2001 From: Joseph Cohen Date: Wed, 11 Mar 2015 15:58:48 -0600 Subject: [PATCH 1/2] User Carbon to query scheduled incidents --- src/Models/Incident.php | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/src/Models/Incident.php b/src/Models/Incident.php index 1725e3c8..4fff9133 100644 --- a/src/Models/Incident.php +++ b/src/Models/Incident.php @@ -2,7 +2,7 @@ namespace CachetHQ\Cachet\Models; -use CachetHQ\Cachet\Facades\Setting as SettingFacade; +use Carbon\Carbon; use CachetHQ\Cachet\Transformers\IncidentTransformer; use Dingo\Api\Transformer\TransformableInterface; use Illuminate\Database\Eloquent\Model; @@ -70,9 +70,7 @@ class Incident extends Model implements TransformableInterface, PresenterInterfa */ public function scopeScheduled($query) { - $timestamp = (new Date())->setTimezone(SettingFacade::get('app_timezone'))->format('Y-m-d H:i:s'); - - return $query->where('status', 0)->where('scheduled_at', '>=', $timestamp); + return $query->where('status', 0)->where('scheduled_at', '>=', Carbon::now()); } /** @@ -85,9 +83,7 @@ class Incident extends Model implements TransformableInterface, PresenterInterfa public function scopeNotScheduled($query) { return $query->where(function ($query) { - $timestamp = (new Date())->setTimezone(SettingFacade::get('app_timezone'))->format('Y-m-d H:i:s'); - - return $query->whereNull('scheduled_at')->orWhere('scheduled_at', '<=', $timestamp); + return $query->whereNull('scheduled_at')->orWhere('scheduled_at', '<=', Carbon::now()); }); } From 912077538f97488efe88adbfed6ebc33940ad976 Mon Sep 17 00:00:00 2001 From: Joseph Cohen Date: Wed, 11 Mar 2015 16:10:25 -0600 Subject: [PATCH 2/2] CS fixes --- app/routes/auth.php | 2 +- src/Http/Controllers/DashScheduleController.php | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/app/routes/auth.php b/app/routes/auth.php index 1a7d14a7..2de63003 100644 --- a/app/routes/auth.php +++ b/app/routes/auth.php @@ -2,7 +2,7 @@ Route::group([ 'prefix' => 'auth', - 'namespace' => 'CachetHQ\Cachet\Http\Controllers' + 'namespace' => 'CachetHQ\Cachet\Http\Controllers', ], function () { Route::group(['before' => 'has_setting:app_name'], function () { // Login routes diff --git a/src/Http/Controllers/DashScheduleController.php b/src/Http/Controllers/DashScheduleController.php index f0358d25..bf1570fa 100644 --- a/src/Http/Controllers/DashScheduleController.php +++ b/src/Http/Controllers/DashScheduleController.php @@ -2,10 +2,9 @@ namespace CachetHQ\Cachet\Http\Controllers; +use CachetHQ\Cachet\Facades\Setting; use CachetHQ\Cachet\Models\Incident; use CachetHQ\Cachet\Models\IncidentTemplate; -use CachetHQ\Cachet\Facades\Setting; -use Carbon\Carbon; use GrahamCampbell\Binput\Facades\Binput; use Illuminate\Routing\Controller; use Illuminate\Support\Facades\Auth;