lucas.mathieu/cachet-docker
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Resolve #3288

Browse Source 
If Binput::get('enabled') is not defined this will return NULL which resulted in a false.
Updated tests
This commit is contained in:
TakeMeNL
2018-12-16 21:51:00 +01:00
parent a7789dc1a6
commit 5f1dfc6249
2 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/Http/Controllers/Api/ComponentController.php
+1 -1
View File
@@ -124,7 +124,7 @@ class ComponentController extends AbstractApiController
Binput::get('link'), Binput::get('link'),
Binput::get('order'), Binput::get('order'),
Binput::get('group_id'), Binput::get('group_id'),
(bool) Binput::get('enabled'), Binput::get('enabled', $component->enabled),
Binput::get('meta', null), Binput::get('meta', null),
(bool) Binput::get('silent', false) (bool) Binput::get('silent', false)
)); ));
tests/Api/ComponentTest.php
+4 -3
View File
@@ -174,7 +174,7 @@ class ComponentTest extends AbstractApiTestCase
]); ]);
$response->assertStatus(200); $response->assertStatus(200);
$response->assertJsonFragment(['name' => 'Foo']); $response->assertJsonFragment(['name' => 'Foo', 'enabled' => $component->enabled]);
} }
public function test_can_update_component_without_status_change() public function test_can_update_component_without_status_change()
@@ -190,7 +190,7 @@ class ComponentTest extends AbstractApiTestCase
]); ]);
$response->assertStatus(200); $response->assertStatus(200);
$response->assertJsonFragment(['name' => 'Foo']); $response->assertJsonFragment(['name' => 'Foo', 'enabled' => $component->enabled]);
} }
public function test_can_update_component_with_status_change() public function test_can_update_component_with_status_change()
@@ -211,7 +211,7 @@ class ComponentTest extends AbstractApiTestCase
]); ]);
$response->assertStatus(200); $response->assertStatus(200);
$response->assertJsonFragment(['name' => 'Foo', 'status' => 2]); $response->assertJsonFragment(['name' => 'Foo', 'status' => 2, 'enabled' => $component->enabled]);
} }
public function test_can_update_component_with_meta_data() public function test_can_update_component_with_meta_data()
@@ -238,6 +238,7 @@ class ComponentTest extends AbstractApiTestCase
'uuid' => '172ff3fb-41f7-49d3-8bcd-f57b53627fa0', 'uuid' => '172ff3fb-41f7-49d3-8bcd-f57b53627fa0',
'foo' => 'bar', 'foo' => 'bar',
], ],
'enabled' => $component->enabled,
]); ]);
} }