From 2b838fef161f6685ba8cfca657164fb904129707 Mon Sep 17 00:00:00 2001 From: James Brooks Date: Mon, 2 Jan 2017 13:35:33 +0000 Subject: [PATCH] We don't need MetricRepository everywhere --- app/Http/Controllers/StatusPageController.php | 38 +++---------------- 1 file changed, 6 insertions(+), 32 deletions(-) diff --git a/app/Http/Controllers/StatusPageController.php b/app/Http/Controllers/StatusPageController.php index c4745f4f..110ba558 100644 --- a/app/Http/Controllers/StatusPageController.php +++ b/app/Http/Controllers/StatusPageController.php @@ -38,25 +38,6 @@ use McCool\LaravelAutoPresenter\Facades\AutoPresenter; */ class StatusPageController extends AbstractApiController { - /** - * The metric repository instance. - * - * @var \CachetHQ\Cachet\Repositories\Metric\MetricRepository - */ - protected $metrics; - - /** - * Construct a new status page controller instance. - * - * @param \CachetHQ\Cachet\Repositories\Metric\MetricRepository $metrics - * - * @return void - */ - public function __construct(MetricRepository $metrics) - { - $this->metrics = $metrics; - } - /** * Displays the status page. * @@ -150,22 +131,15 @@ class StatusPageController extends AbstractApiController */ public function getMetrics(Metric $metric) { - $metricData = []; $type = Binput::get('filter', 'last_hour'); + $metrics = app(MetricRepository::class); switch ($type) { - case 'last_hour': - $metricData = $this->metrics->listPointsLastHour($metric); - break; - case 'today': - $metricData = $this->metrics->listPointsToday($metric); - break; - case 'week': - $metricData = $this->metrics->listPointsForWeek($metric); - break; - case 'month': - $metricData = $this->metrics->listPointsForMonth($metric); - break; + case 'last_hour': $metricData = $metrics->listPointsLastHour($metric); break; + case 'today': $metricData = $metrics->listPointsToday($metric); break; + case 'week': $metricData = $metrics->listPointsForWeek($metric); break; + case 'month': $metricData = $metrics->listPointsForMonth($metric); break; + default: $metricData = []; } return $this->item([